Skip to content

Conversation

TrySound
Copy link
Member

Ref #3691

Editing search params separately from url can improve experience working with external CMS or databases like baserow.

Also made headers list more compact and aligned with search params.
Validation is simplified, empty pairs will be just ignored without blocking user with validation errors.

search-params.mp4

Ref #3691

Editing search params separately from url can improve experience working
with external CMS or databases like baserow.
@TrySound TrySound requested a review from kof August 31, 2025 12:42
@kof
Copy link
Member

kof commented Aug 31, 2025

  • Something happened to new variable panel position
image

@kof
Copy link
Member

kof commented Aug 31, 2025

  • empty state feels like something is missing, probably needs to say "No search params" and "No headers" to make visually clear that these are sections
image

@kof
Copy link
Member

kof commented Aug 31, 2025

Ideally we would show the search params in the URL as you add them via inputs and when URL changes inputs get added/removed automatically

image

@kof
Copy link
Member

kof commented Aug 31, 2025

I can imagine having autocompletion for standard header names would be very helpful

@kof
Copy link
Member

kof commented Aug 31, 2025

  • when adding a search param via + button, I would autofocus the first input
image

@TrySound
Copy link
Member Author

Something happened to new variable panel position

Same as resource variable

Ideally we would show the search params in the URL as you add them via inputs and when URL changes inputs get added/removed automatically

Can be deceiving for user. URL is also an actual input. Dunno why put there.

@kof
Copy link
Member

kof commented Aug 31, 2025

Same as resource variable

Not sure what you mean, its now in the middle but it should be next to the settings panel

@TrySound
Copy link
Member Author

Resource panel is variable panel and it is centered now for better preview. Works with system and big json data too.

image image

@kof
Copy link
Member

kof commented Sep 1, 2025

What's a little off is that the panel is so small and sits in the middle of the screen, we could potentially solve this by showing the data preview always, so its always not small

@kof
Copy link
Member

kof commented Sep 1, 2025

Another thing I noticed is after switching from a Resource with data in it to a string, you still see data in the preview and only once I refresh I see the value preview

image image

@TrySound TrySound merged commit cdb2a95 into main Sep 1, 2025
17 checks passed
@TrySound TrySound deleted the search-params branch September 1, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants